Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick search in whole commit message if loaded #9320

Merged
merged 1 commit into from Jul 5, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Jul 1, 2021

Proposed changes

  • Quick search Body - instead of just Subject - if available

Test methodology

  • manual:
    • focus RevisionGrid
    • type "cherry"
    • hit Alt+Down
      should find cherry-picks

Test environment(s)

  • Git Extensions 33.33.33
  • Build 2e3fce4
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET 5.0.7
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Jul 1, 2021
@gerhardol
Copy link
Member

Is this the second part of #9317 (comment)?

@mstv
Copy link
Member Author

mstv commented Jul 1, 2021

Yes, it is.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that this quick search applies to what you see in the grid. This should maybe be related to the new setting to see the body in the grid.

@mstv
Copy link
Member Author

mstv commented Jul 2, 2021

I expect that this quick search applies to what you see in the grid.

That would be a clear definition in comparison to "... if body loaded". But the result would be counterintuitive to me since the whole message of the selected commit is visible always - located right of the RevisionGrid, (where it should be displayed by default - perhaps left for RTL languages).

It should behave similar as
grafik

@gerhardol
Copy link
Member

I meant if this is set:
image

Like searching in a document

@mstv
Copy link
Member Author

mstv commented Jul 3, 2021

I expect that this quick search applies to what you see in the grid.
Like searching in a document

I think I had understood what you mean.
What about "quick search applies to what you can see in the grid - including the tooltip"?

@gerhardol
Copy link
Member

I expect that this quick search applies to what you see in the grid.
Like searching in a document

I think I had understood what you mean.
What about "quick search applies to what you can see in the grid - including the tooltip"?

Ok

@mstv mstv merged commit 2ba9fa5 into gitextensions:master Jul 5, 2021
@ghost ghost added this to the 3.6 milestone Jul 5, 2021
@mstv mstv deleted the fix/quick_search_body branch July 5, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants