Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BashShell: Try git-bash.exe first #9430

Merged
merged 1 commit into from Aug 2, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Aug 1, 2021

#9416 for master
Fixes #9353
not completely - but the regression from #8213
git-bash.exe cannot be used for the built-in console.
As I explained in #9353 (comment), bash.exe ignores the path to git.exe added by GE to PATH.

Proposed changes

  • BashShell: Try git-bash.exe first for stand-alone shell
  • search also in the 64-bit-programs folder

Screenshots

Before

image

After

image

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build e54cd4e
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4360.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

and search also in the 64-bit-programs folder
@mstv mstv self-assigned this Aug 1, 2021
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in release/3.5

@mstv mstv merged commit 7afcb01 into gitextensions:master Aug 2, 2021
@ghost ghost added this to the 3.6 milestone Aug 2, 2021
@mstv mstv deleted the fix/9353_git-bash.exe branch August 2, 2021 22:29
Kingsizehss pushed a commit to Kingsizehss/gitextensions that referenced this pull request Aug 3, 2021
and search also in the 64-bit-programs folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git executable not found in Console
2 participants