Artificial commits: Invalidate rowcache when inserting #9459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Aug 9, 2021
GintasS
reviewed
Aug 9, 2021
GintasS
approved these changes
Aug 9, 2021
mstv
approved these changes
Aug 9, 2021
You know this better than me... But I tried to add comments with what I know. Will squash merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #9393
Proposed changes
Inserting artificial commits first if HEAD was not added to the grid was added in #9393.
In some situations the grid would not be refreshed correctly, requiring a manual scroll.
This normally would occur for bigger repos only.
When working with the PR, I could not get a stable repro and could not address it.
This is a follow up to invalidate the row cache properly to refresh the graph in the grid.
Screenshots
Before
After
The normal commits are being displayed while the git-log output is created, so initially the artificial commits are not shown.
After a few seconds the graph is updated as below (that would require a scroll before).
Test methodology
manual
✒️ I contribute this code under The Developer Certificate of Origin.