Reset revision filter when switching repos #9477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
reviewed
Aug 11, 2021
There was a problem hiding this comment.
The issue reports on the Advanced filter, paths, but the PR handles the toolbar revision filter. The revision is also relevant though.
However, I have made the path filter change in #9445, will adopt that to all items and push to this branch.
| @@ -1978,6 +1978,7 @@ private void SetGitModule(object sender, GitModuleEventArgs e) | |||
| _gitStatusMonitor.InvalidateGitWorkingDirectoryStatus(); | |||
| _submoduleStatusProvider.Init(); | |||
| ToolStripFilters.SetBranchFilter(string.Empty, refresh: false); | |||
| ToolStripFilters.SetRevisionFilter(string.Empty); | |||
There was a problem hiding this comment.
Note for other reviewers: revision filters can be set at FormBrowse startup (as command lind arguments), but SetGitModule() does not execute at startup so filters are not cleared.
|
Thank you, I was mostly oblivious about other filter dialogs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3153
✒️ I contribute this code under The Developer Certificate of Origin.