Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CorePath class #9540

Merged
merged 1 commit into from Aug 29, 2021
Merged

Remove CorePath class #9540

merged 1 commit into from Aug 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2021

ConfigFileSettings class is complex. I would like to simplify it.

Proposed changes

  • Take a general approach
  • Clearer implementation

Test methodology

  • unit tests
  • manually

Test environment(s)

  • Git Extensions 33.33.33
  • Build 008ad87
  • Git 2.30.2.windows.1
  • Microsoft Windows NT 10.0.19043.0
  • .NET 5.0.9
  • DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost self-assigned this Aug 29, 2021
@RussKie
Copy link
Member

RussKie commented Aug 29, 2021

Welcome back 😉

@RussKie RussKie merged commit ac84e8e into gitextensions:master Aug 29, 2021
@ghost ghost added this to the 3.6 milestone Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants