NBug: Include GE specific exception info

[gerhardol]

Debug info for #9560 etc , needed after #9056

Proposed changes

• Fix regression: Separated BugReporter and Throw on non-zero exit code and on stderror output #9056 was done in separate branches.

When a Git command exits with errors, info about current directory, arguments etc is collected and presented in a popup.
This info is now also included in rthe NBug report.

Note: StandardError should be included as well as in Git Command Log, this a separate PR.

The popup is unchanged:

A cut exception below (as well as modified formatting), adding the three lines below ## Error Details

## Error Details

Command: C:\Program Files\Git\bin\git.exe
Arguments: -c color.ui=never -c diff.submodule=short -c diff.noprefix=false -c diff.mnemonicprefix=false -c diff.ignoreSubmodules=none -c core.safecrlf=false diff --find-renames --find-copies --name-status "07f7352af399f9da9923327abde3988d528c4205" "7caf16f7fcd2398b05b7d25de8e61d7205200094"
Working directory: C:\dev\gc\gitextensions_4\Externals\conemu-insidew\

GitExtUtils.ExternalOperationException: The directory name is invalid.
   at ExecutionResult GitCommands.GitModule.GetDiffFiles(string firstRevision, string secondRevision, bool noCache, bool nullSeparated) in C:/dev/gc/gitextensions_4/GitCommands/Git/GitModule.cs:line 2388
   at string ResourceManager.LocalizationHelpers.ProcessSubmoduleStatus(GitModule module, GitSubmoduleStatus status, bool moduleIsParent, bool limitOutput) in C:/dev/gc/gitextensions_4/ResourceManager/LocalizationHelpers.cs:line 289
   at async Task GitUI.GitUIExtensions.ViewChangesAsync(FileViewer fileViewer, FileStatusItem item, CancellationToken cancellationToken, string defaultText, Action openWithDiffTool)+GetSelectedPatchAsync(?) in C:/dev/gc/gitextensions_4/GitUI/GitUIExtensions.cs:line 146
   at async Task GitUI.GitUIExtensions.ViewChangesAsync(FileViewer fileViewer, FileStatusItem item, CancellationToken cancellationToken, string defaultText, Action openWithDiffTool) in C:/dev/gc/gitextensions_4/GitUI/GitUIExtensions.cs:line 94
   at async Task GitUI.CommandsDialogs.RevisionDiffControl.ShowSelectedFileDiffAsync() in C:/dev/gc/gitextensions_4/GitUI/CommandsDialogs/RevisionDiffControl.cs:line 479
   at async void GitUI.CommandsDialogs.RevisionDiffControl.DiffFiles_SelectedIndexChanged(object sender, EventArgs e)+(?) => { } in C:/dev/gc/gitextensions_4/GitUI/CommandsDialogs/RevisionDiffControl.cs:line 488
   at async void GitUI.ThreadHelper.FileAndForget(Task task, Func<Exception, bool> fileOnlyIf)+(?) => { } in C:/dev/gc/gitextensions_4/GitExtUtils/GitUI/ThreadHelper.cs:line 100

Test methodology

Tests adapted

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

---

✒️ I contribute this code under The Developer Certificate of Origin.

[RussKie]

👍

[RussKie]

Please revert back

[gerhardol]

I would like to have a comment with how to debug the BugReporter when the debugger is in use
What do you suggest?
Is the commented out code bothering you?

[gerhardol]

Keeping when squash merging in about a day unless clarified

[RussKie]

What's the difference between exception and exceptionInfo and why the latter can't be derived from the former?

[gerhardol]

GE specific exceptions like GitExtUtils.ExternalOperationException are not available in BugReporter, so the summary for GE internal exceptions are passed as a string.

[RussKie]

Please add this comment as xml-doc

[gerhardol]

done

[RussKie]

Merge at will