Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rename menu item for remote branches from Repo Tree #9625

Merged
merged 1 commit into from Oct 8, 2021

Conversation

mdonatas
Copy link
Contributor

@mdonatas mdonatas commented Oct 7, 2021

Proposed changes

  • Turns out it is impossible to rename remote branches thus remote branch nodes should not have a Rename menu item

Test methodology

  • Manually - context menu for remote branch no longer has Rename

Before

image

After

image

Test environment(s)

  • Git Extensions 3.4.3
  • Build a5af927 (Dirty)
  • Git 2.33.0.windows.2
  • Microsoft Windows NT 10.0.19043.0
  • .NET Framework 4.8.4420.0
  • DPI 192dpi (200% scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned mdonatas Oct 7, 2021
@RussKie
Copy link
Member

RussKie commented Oct 8, 2021

How can we rename a remote?
I see we have a menu available in the left tree, but AFAIK it is not possible to rename a remove branch and this was never exposed in the revision grid.

And if I try to rename a remote initiating the flow from the left panel it errors out:
image

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Oct 8, 2021
@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Oct 8, 2021
@mdonatas mdonatas changed the title Fix F2 on remote branch Remove Rename menu item for remote branches from Repo Tree Oct 8, 2021
@mdonatas mdonatas requested a review from mstv October 8, 2021 07:31
@mdonatas
Copy link
Contributor Author

mdonatas commented Oct 8, 2021

Thanks @RussKie nice catch! I was working on a keyboard shortuct related change and simply noticed this was broken from that perspective. Didn't occur to question the feature itself since there was a menu item after all.

Updated PR comment and code to reflect this new reality.

@RussKie RussKie merged commit 9629c5a into gitextensions:master Oct 8, 2021
@RussKie
Copy link
Member

RussKie commented Oct 8, 2021

Thank you

@RussKie RussKie added this to the 3.6 milestone Oct 8, 2021
@mdonatas mdonatas deleted the fix-f2-on-remote-branch branch October 12, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants