Add support for Del key to RepoObjectsTree nodes

[mdonatas]

Motivation

When cleaning up branches it is very convenient to do that from the repo objects tree panel as the branches are sorted by date and it's easy to choose unnecessary ones. However having to open a context menu and click on Delete menu item is a big hurdle when compared to the whole process. It's actually easier to click on a line in a rev-grid and press del when focus is there. Enabling del key in repo objects tree panel solves that.

Proposed changes

• Enable triggering Delete form for repo objects tree items with a del key
• Implementation is exactly the same as is already done for triggering Rename form with F2 key

Screenshots

Before

After

Test methodology

• Manually. Pressing del key on a local branch, remote branch and tag opens up delete form

Test environment(s)

• Git Extensions 33.33.33
• Build 28321b0
• Git 2.33.0.windows.2
• Microsoft Windows NT 10.0.19043.0
• .NET 5.0.10
• DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

[vbjay]

Hurdle is kinda on purpose.

…

On Fri, Oct 8, 2021, 10:41 AM Donatas Mačiūnas ***@***.***> wrote: Motivation When cleaning up branches it is very convenient to do that from the repo objects tree panel as the branches are sorted by date and it's easy to choose unnecessary ones. However having to open a context menu and click on Delete menu item is a big hurdle when compared to the whole process. It's actually easier to click on a line in a rev-grid and click del when focus is there. Enabling del key in repo objects tree panel solves that. Proposed changes - Enable triggering Delete form for repo objects tree items with a del key - Implementation is exactly the same as is already done for triggering Rename form with F2 key Screenshots Before [image: image] <https://user-images.githubusercontent.com/483659/136575419-09517b69-3075-481d-8554-93496f89bb56.png> [image: image] <https://user-images.githubusercontent.com/483659/136575430-624a528d-5262-4e10-aa3e-3e0454ae9fcb.png> [image: image] <https://user-images.githubusercontent.com/483659/136575442-0d9a8192-a06e-41b9-96c9-827231b53d5a.png> After [image: image] <https://user-images.githubusercontent.com/483659/136574697-26b39acb-5c2f-45d7-b9bb-4d7366364683.png> [image: image] <https://user-images.githubusercontent.com/483659/136574722-31abbd8b-7191-4e69-87ed-af3bee578264.png> [image: image] <https://user-images.githubusercontent.com/483659/136574731-03bff5f3-a74b-4f15-bd86-02aba2f2e738.png> Test methodology - Manually. Pressing del key on a local branch, remote branch and tag opens up delete form Test environment(s) - Git Extensions 33.33.33 - Build 28321b0 <28321b0> - Git 2.33.0.windows.2 - Microsoft Windows NT 10.0.19043.0 - .NET 5.0.10 - DPI 96dpi (no scaling) Merge strategy I agree that the maintainer squash merge this PR (if the commit message is clear). ✒️ I contribute this code under The Developer Certificate of Origin <http://../blob/master/contributors.txt>. ------------------------------ You can view, comment on, or merge this pull request online at: #9630 Commit Summary - Add support for Del key to RepoObjectsTree nodes <28321b0> File Changes - *M* GitUI/BranchTreePanel/ContextMenu/MenuItemsGenerator.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-0b571a54371bb2e4469ac14185cc268931d7c9729502513b6ffeecfaac247535> (7) - *M* GitUI/BranchTreePanel/RepoObjectsTree.LocalBranchNode.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-18460bcf18d3c5cea5ff2eea7fecee929dd6df8c03cbf9455728ce327043d056> (5) - *M* GitUI/BranchTreePanel/RepoObjectsTree.Nodes.Tags.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-a9b7606fc3ee8f9a6e79ac79aa4e0cf4691aedae31e5e1543bdb513edc640af7> (5) - *M* GitUI/BranchTreePanel/RepoObjectsTree.Nodes.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-0e4e4cb1cf55dda2f8779cc7ddc8df12a1facb0cb4768db703510db95037c5fc> (4) - *M* GitUI/BranchTreePanel/RepoObjectsTree.RemoteBranchNode.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-b48f20b5137826efa3c607d100df19082721e6877cfde8dfd11cca4f6d1050bc> (5) - *M* GitUI/BranchTreePanel/RepoObjectsTree.cs <https://github.com/gitextensions/gitextensions/pull/9630/files#diff-30898bcfc538da9210d67dd18ba2b70a86fa054f3b353d0f45747dca0558d408> (3) Patch Links: - https://github.com/gitextensions/gitextensions/pull/9630.patch - https://github.com/gitextensions/gitextensions/pull/9630.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9630>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3WDMLCOTW6OIGNJDELYGLUF37H5ANCNFSM5FTYYU6Q> .

[mdonatas]

Hurdle is kinda on purpose.

This is an extra hurdle on top of a confirmation dialog "hurdle" and then an additional confirmation "hurdle" so there seems to be enough hurdle already :)
By the way del key works fine if you focus a row in FormBrowse which has a branch so this only equalizes the amount of hurdle between them.

[vbjay]

Oh ok. I see what you mean. I'd just make sure it only works when the menu would show and be enabled.

…

On Fri, Oct 8, 2021, 11:01 AM Donatas Mačiūnas ***@***.***> wrote: Hurdle is kinda on purpose. This is an extra hurdle on top of a confirmation dialog "hurdle" and then an additional confirmation "hurdle" so there seems to be enough hurdle already :) By the way del key works fine if you focus a row in FormBrowse which has a branch so this only equalizes the amount of hurdle between them. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9630 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3WDMMRDCTI2NDWF36I6CTUF4BV5ANCNFSM5FTYYU6Q> .

[RussKie]

Thank you