Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushLocalCmd: path must be absolute #9678

Merged

Conversation

gerhardol
Copy link
Member

Contributes to #8172

Proposed changes

"Reset another branch" uses "push .".
This is not supported in the documentation or with other than Windows Git.
This therefore fails with WSL Git, must use "file://" prefix.

Test methodology

Tests updated

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Oct 24, 2021
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible. Have not run.

@RussKie RussKie merged commit 8066c59 into gitextensions:master Oct 24, 2021
@ghost ghost added this to the vNext milestone Oct 24, 2021
@gerhardol gerhardol deleted the feature/i8172-wsl-reset-another-branch branch October 24, 2021 21:59
@mdonatas
Copy link
Contributor

This broke it for git for windows though.

C:\Users\donat>git push "file://C:\Workplace\personal\gitextensions" "d438294599d9c0737e84fbd013e1939b9b80a8f5:refs/heads/test"
fatal: not a git repository (or any of the parent directories): .git

@gerhardol
Copy link
Member Author

This broke it for git for windows though.

See #9698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants