Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar dpi scaling issue #9684

Merged
merged 1 commit into from Oct 26, 2021

Conversation

pmiossec
Copy link
Member

@pmiossec pmiossec commented Oct 25, 2021

Proposed changes

  • Scaling is not good for filter toolstrip

Screenshots

Before

image

After

image

Test methodology

  • 馃憖

Test environment(s)

  • Git Extensions 33.33.33
  • Build b90b648 (Dirty)
  • Git 2.28.0.windows.1 (recommended: 2.30.0 or later)
  • Microsoft Windows NT 10.0.19042.0
  • .NET 5.0.11
  • DPI 192dpi (200% scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


鉁掞笍 I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned pmiossec Oct 25, 2021
@RussKie
Copy link
Member

RussKie commented Oct 26, 2021

Judging by the screenshots it doesn't look like it is truly fixed:
image

@RussKie RussKie added the 馃摥 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Oct 26, 2021
@pmiossec
Copy link
Member Author

If you are talking about the top of the filterboxes missing, I didn't noticed that I did a bad screenshot. Here is a good on (I will update the one in the PR description):

image

@ghost ghost removed the 馃摥 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Oct 26, 2021
@RussKie RussKie merged commit 1a9098c into gitextensions:master Oct 26, 2021
@ghost ghost added this to the vNext milestone Oct 26, 2021
@pmiossec pmiossec deleted the fix_toolbar_dpi_issue branch October 27, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants