GitStatusMonitor could start multiple commands #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
force-pushed
the
feature/i9615-gitstatus-multiple
branch
from
1fab8da
to
79473a0
Compare
If If the monitor was inactivated while a status command was running (minimizing/restoring the app, start a modal dialog) the current command is canceled to give the latest data. lock() will ensure that more than one "active" command is not running. However, one control variable was reset also if the command was canceled which allowed the canceled command to be followed by another. Also changed to not request a new status command if a command is already running. (current status should be good enough, if there are pending changes they will be requested later). Some refactoring and cleanups.
gerhardol
force-pushed
the
feature/i9615-gitstatus-multiple
branch
from
79473a0
to
4a94321
Compare
|
still under test (a first variant of this PR stopped updating after a few days and did not recover) |
mstv
approved these changes
Dec 3, 2021
|
Plan to merge this in a couple of days. |
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Dec 5, 2021
If the monitor was inactivated while a status command was running (minimizing/restoring the app, start a modal dialog) the current command is canceled to give the latest data. lock() will ensure that more than one "active" command is not running. However, one control variable was reset also if the command was canceled which allowed the canceled command to be followed by another. Also changed to not request a new status command if a command is already running. (Current status should be good enough, if there are pending changes they will be requested later.) Cherry picked essential changes from master: gitextensions#9700/e2630a6c5b09452b0a0ef7a3ff169083c3fcb7c4
gerhardol
added a commit
that referenced
this pull request
Dec 5, 2021
If the monitor was inactivated while a status command was running (minimizing/restoring the app, start a modal dialog) the current command is canceled to give the latest data. lock() will ensure that more than one "active" command is not running. However, one control variable was reset also if the command was canceled which allowed the canceled command to be followed by another. Also changed to not request a new status command if a command is already running. (Current status should be good enough, if there are pending changes they will be requested later.) Cherry picked essential changes from master: #9700/e2630a6c5b09452b0a0ef7a3ff169083c3fcb7c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9615
See also #9700 for 3.5, with the essential correction (most of the changes was done first to find the problem).
Proposed changes
If If the monitor was inactivated while a status command was running
(minimizing/restoring the app, start a modal dialog) the current command
is canceled to give the latest data.
lock() will ensure that more than one "active" command is not running.
However, one control variable was reset also if the command was canceled
which allowed the canceled command to be followed by another.
Also changed to not request a new status command if a command is already
running. (current status should be good enough, if there are pending
changes they will be requested later).
Some refactoring and cleanups.
Test methodology
Manual testing
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.