RevisionGridControl: prevent exception when switching repository #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Nov 6, 2021
Comment on lines
+582
to
+586
| if (index >= _gridView.Rows.Count) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can you please add a comment describing a situation that leads to this path?
RussKie
added
the
📭 needs: author feedback
pmiossec
force-pushed
the
prevent_exception
branch
from
e613257
to
f966ece
Compare
ghost
removed
the
📭 needs: author feedback
gerhardol
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nothing, just improve UX in DEBUG inside Visual Studio
Proposed changes
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).