New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppTitle was set to previous repo branch #9725
Merged
gerhardol
merged 2 commits into
gitextensions:master
from
gerhardol:feature/i9553-app-title
Nov 14, 2021
Merged
AppTitle was set to previous repo branch #9725
gerhardol
merged 2 commits into
gitextensions:master
from
gerhardol:feature/i9553-app-title
Nov 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned gerhardol
Nov 13, 2021
mstv
reviewed
Nov 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, have not run
RussKie
approved these changes
Nov 14, 2021
Except when starting the first time directly to a repo
gerhardol
force-pushed
the
feature/i9553-app-title
branch
from
November 14, 2021 00:54
190dbad
to
87a0a52
Compare
ghost
added this to the vNext milestone
Nov 14, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 14, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 14, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 14, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 19, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 20, 2021
RussKie
pushed a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 21, 2021
RussKie
pushed a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 21, 2021
RussKie
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 21, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 21, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originates in #9553 or similar that reworked the FormBrowse and filter init logic.
Proposed changes
Except when starting the first time directly to a repo, the title was set to the previous repo as it used info not yet updated.
When starting from Dashboard, the path was empty.
This operation is reading refs/ normally, so not delaying the operation.
(In another PR, there is a an optimization swapping the other way...)
In addition add start to Dashboard a debug profile to simplify testing starting from Dashboard.
Screenshots
Before
After
Test methodology
Manual
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.