Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppTitle was set to previous repo branch #9725

Merged
merged 2 commits into from Nov 14, 2021

Conversation

gerhardol
Copy link
Member

This originates in #9553 or similar that reworked the FormBrowse and filter init logic.

Proposed changes

Except when starting the first time directly to a repo, the title was set to the previous repo as it used info not yet updated.
When starting from Dashboard, the path was empty.
This operation is reading refs/ normally, so not delaying the operation.
(In another PR, there is a an optimization swapping the other way...)

In addition add start to Dashboard a debug profile to simplify testing starting from Dashboard.

Screenshots

Before

image

After

image

image

Test methodology

Manual

Merge strategy

  • Rebase merge (PR submitter must change the commit message for the last commit).

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Nov 13, 2021
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, have not run

Except when starting the first time directly to a repo
@gerhardol gerhardol merged commit 9f20eb5 into gitextensions:master Nov 14, 2021
@ghost ghost added this to the vNext milestone Nov 14, 2021
@gerhardol gerhardol deleted the feature/i9553-app-title branch November 14, 2021 08:29
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 14, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 14, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 14, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 19, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 20, 2021
RussKie pushed a commit to gerhardol/gitextensions that referenced this pull request Nov 21, 2021
RussKie pushed a commit to gerhardol/gitextensions that referenced this pull request Nov 21, 2021
RussKie added a commit to gerhardol/gitextensions that referenced this pull request Nov 21, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 21, 2021
gerhardol added a commit to gerhardol/gitextensions that referenced this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants