LeftPanel was initiated twice at startup #9734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
force-pushed
the
feature/i9553-do-not-init-left-panel-twice
branch
from
a8fc913
to
ff8d913
Compare
RussKie
reviewed
Nov 17, 2021
gerhardol
force-pushed
the
feature/i9553-do-not-init-left-panel-twice
branch
from
ff8d913
to
800e6ba
Compare
gerhardol
force-pushed
the
feature/i9553-do-not-init-left-panel-twice
branch
from
800e6ba
to
ce01843
Compare
gerhardol
force-pushed
the
feature/i9553-do-not-init-left-panel-twice
branch
from
ce01843
to
ff71b3c
Compare
|
Moved a commit from #9735 to this PR, rebased. |
mstv
reviewed
Dec 2, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Dec 3, 2021
mstv
reviewed
Dec 3, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Dec 3, 2021
mstv
approved these changes
Dec 3, 2021
When WorkingDirectory is null or no revision is selected
Information is already available in the method.
gerhardol
force-pushed
the
feature/i9553-do-not-init-left-panel-twice
branch
from
9356fdd
to
b818b2e
Compare
|
Squ7ashed and rebased, rebase merge tomorrow |
|
👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in master
Based on #9729 (may be separated).
Ready for review (first commit is not to be considered) even if draft.
Proposed changes
The structuring of FormBrowse in master has changed so the left panel is initiated both at creation and at PostRepositoryChanged.
This could add a couple of seconds to the startup. (Especially at work with virus programs.)
Also eliminate a few Git calls when starting to Dashboard.
(More confusing than a problem.)
Screenshots
Before
After
Test methodology
Manual
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.