Make the Debug build debuggable #9744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An addendum to gitextensions#9704. The .NET bootstrap created a .NET Framework entry point. This tricks the debugger, and it doesn't see the app as a .NET process, and, thus, unable to hit any breakpoints. To mitigate this, only apply the bootstrap to the Release configuration.
ghost
assigned 
|
Can this be changed to allow tests in Debug too? |
|
Bugger! Let's pull the debug assert. If you can make a PR and merge -
that'd be great. I'll see if I can come up fix a better was to assert later.
|
|
Disabling privately for now, there must be a better way. |
|
There are also random "Unhandled exception" popups that hang tests (occurred before this change). The reason for the illegal directory is unknown.
|
RussKie
added a commit
to RussKie/gitextensions
that referenced
this pull request
Nov 21, 2021
An addendum to gitextensions#9744
Merged
Tyrrrz
reviewed
Nov 28, 2021
|
|
||
| // Under DotnetRuntimeBootstrapper this points to C:\Program Files\dotnet\dotnet.exe | ||
| // whereas we need our executable | ||
| private static string _applicationExecutablePath = Assembly.GetEntryAssembly().Location.Replace(".dll", ".exe"); |
There was a problem hiding this comment.
Note: it's safer to use Path.ChangeExtension(...) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An addendum to #9704.
Proposed changes
To mitigate this, only apply the bootstrap to the Release configuration.
Resolves [NBug] Could not find a part of the path 'C:\Program Files\dotnet\... #9743