Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .NET Runtime Bootstrapper #9767

Merged
merged 3 commits into from Dec 7, 2021
Merged

Update .NET Runtime Bootstrapper #9767

merged 3 commits into from Dec 7, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Dec 6, 2021

Fixes #9766

Proposed changes

  • Update DotnetRuntimeBootstrapper to latest version
  • Revert the workaround for getting application path (it should now resolve correctly)
  • Remove condition on package reference (bootstrapper is now only generated on publish, not on build)

Test methodology

  • I tested it manually :)

Test environment(s)

  • GIT 2.31.1.windows.1
  • Windows 10.0.19043.1348

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned Tyrrrz Dec 6, 2021
gerhardol
gerhardol reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Seem OK to me

@RussKie RussKie merged commit 817fa4e into gitextensions:master Dec 7, 2021
@ghost ghost added this to the vNext milestone Dec 7, 2021
@RussKie
Copy link
Member

RussKie commented Dec 7, 2021

Thank you

@Tyrrrz Tyrrrz deleted the update-bootstrapper branch December 7, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerhardol gerhardol gerhardol left review comments

@RussKie RussKie RussKie approved these changes

@GintasS GintasS Awaiting requested review from GintasS

Assignees

@Tyrrrz Tyrrrz

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Update DotnetRuntimeBootstrapper to latest version to make use of added improvements
3 participants
@Tyrrrz @RussKie @gerhardol