Support colorblind variation of default theme #9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
approved these changes
Jan 6, 2022
|
|
||
| _context.Controller.ShowThemeSettings(); | ||
|
|
||
| _context.Page.IsChoosingThemeVariationsEnabled.Should().BeTrue(); |
There was a problem hiding this comment.
IsChoosingThemeVariationsEnabled is always enabled, property can be removed
| .Branch { color: #00d76b; } | ||
| .Branch.colorblind { color: #0080ff; } /* hsl(210, 100%, 50%) */ | ||
|
|
||
| .RemoteBranch { color: #ff8080; } /* hsl(0, 100%, 75%) */ |
There was a problem hiding this comment.
nit pick and not from this PR: Can the colors be ordered as in the other themes so they are easier to compare?
| { | ||
| "colorblind", new() | ||
| { | ||
| { AppColor.Graph, Color.FromArgb(0x06, 0x00, 0xa8) }, |
There was a problem hiding this comment.
Question: The invarientTheme is read from invariant.css, these are hardcoded in the app.
Is there a reason for this?
I would expect the invariant theme to be hardcoded, but it is nice to have the colors listed in a file too.
(Still hoping themes can return...)
There was a problem hiding this comment.
I agree, I don't like having both hardcoded colors and .css colors either. Would rather keep everything in .css for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Default theme uses hardoded color values. Add hardcoded color values for colorblind variation as well.
Screenshots
Test methodology
Tested manually
ColorSettingsPage logic to not disable colorblind checkbox is covered by unit test
Test environment(s)
Windows 10
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.