ShowSimplifyByDecoration: Not dependent on branch filter #9808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShowSimplifyByDecoration has been incorrectly set as dependent of Branches filter (at least since 2.51). This is an independent revision filter.
ghost
assigned 
RussKie
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4642
Fixes #9548
Fixes #7354
(This is really initiated by looking at documentation, issues are found later.)
Proposed changes
ShowSimplifyByDecoration has been incorrectly set as dependent of
Branches filter (at least since 2.51). This is an independent revision filter.
https://git-scm.com/docs/git-log#Documentation/git-log.txt---simplify-by-decoration
This PR disconnects the option from Branches.
The implementation can probaly be done better, this is just better than what is.
Enabling the option shows the commits with branches/tags only
Screenshots
Before
After
Tooltip when active
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.