Ignore nonexisting submodule paths #9819
Conversation
ghost
assigned 
|
Should we provide a button/link to open submodules management dialog?
|
I rather keep this simple, there are other PRs that I want to have merged... |
|
I'm worried that an average Joe user may not know what to do when these messages pop up. A link to "Manage submodules" will provide a significantly more positive experience. |
gerhardol
force-pushed
the
feature/i9612-no-directory-browse
branch
from
74d3b95
to
bfee15f
Compare
Done
I just want something good enough. This is better than the igore or error popup in 3.5 or the popup after #9056 in master. |
| @@ -93,6 +93,12 @@ protected override string NodeName() | |||
|
|
|||
| public void Open() | |||
| { | |||
| if (!Directory.Exists(Info.Path)) | |||
| { | |||
| MessageBoxes.SubmoduleDirectoryDoesNotExist(null, Info.Path, Info.Text); | |||
There was a problem hiding this comment.
Give the null parameter name. Why is it null? The error will be unparented, and can get lost behind other windows.
There was a problem hiding this comment.
changed to this where possible (not in side panel or the generic Launch).
gerhardol
force-pushed
the
feature/i9612-no-directory-browse
branch
from
bfee15f
to
0a3e671
Compare
Show MessageBox with submodule information
gerhardol
force-pushed
the
feature/i9612-no-directory-browse
branch
from
b95f513
to
7884381
Compare
|
Plan to squash merge tomorrow. |
Fixes #8366
Proposed changes
Show MessageBox with submodule information
Replaces #9612, also some other situations handling #9056
This could be done in a nicer way, but this is important to point users in a better direction just not ignoring (as in 3.5) or showing a popup recommending to report an issue on GE (as in master).
For users, the behavior in master seem like a regression.
Note that the popup is shown two times when opening a repo (structure and status) then periodically when status is updated. (So did the Validate error.)
The popup could be limited to be shown for just the first popup when the structure has been updated, but this is an error in the repo setup.
See this (auto closed) PR for how to recreate the issue.
This is easiest done by deleting or renaming a submodule.
This also occurred when doubleclicking a submodule no longer existing, for instance the GitExtensionsDoc for commits two years ago.
Some occurrences like doubleclicking a deleted submodule in RevDiff was previously just ignored.
Screenshots
Before
See also #9612
After
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.