Blame: Start on line also when control already exists #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mstv
approved these changes
Jan 23, 2022
Blame can start presenting on a line. This is is available in RevDiff and RevFileTree since gitextensions#9424. (Even if the code enabling this has existed for long time, it was just used for a special case.) The "goto line" was only used if the control had to be init, not if e.g. toggling to Diff and selecting an new diff line and then Blame again.
gerhardol
force-pushed
the
feature/i9796-blame-line-number-1
branch
from
49ddf11
to
0e518e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the core change in #9805
To add tests to this, a lot more has to be changed and this change is useful to functional testing other upcoming GoToLine changes,
so it was broken out to a separate PR.
#9805 is kept to handle the tests.
Proposed changes
Blame can start presenting on a line. This is is available in
RevDiff and RevFileTree since #9424.
(Even if the code enabling this has existed for long time,
it was just used for a special case.)
The "goto line" was only used if the control had to be init,
not if e.g. toggling to Diff and selecting an new diff line
and then Blame again.
Screenshots
See #9805
Test methodology
Manual - tests in #9805
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.