Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share gitRefs when reloading after changing sort criterias #9896

Merged

Conversation

gerhardol
Copy link
Member

Part of #9888 (that is follow up to #9864)

Leaves the "double side panel init" to later.
#9884 is already approved but have a refresh issue that I do not know how to solve in a good way and therefore separate most of the changes.

Proposed changes

  • Changing filters required 3 separate getRefs() calls (so it could be slower than refreshing the complete grid).
  • Share getRefs() after loading the grid when filters are applied (normally, this is not needed though if the structure is not rebuilt).

Getting refs can take >10s in large repos and should only not be done 3 times when only one is needed.
Future: This could possibly be cached too, requiring an "external" refresh to reread the cache.

Screenshots

For changing sort criteria

Before

image

After

resort-2

Test methodology

Manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned gerhardol Mar 13, 2022
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refs rather is getRefs.

GitUI/BranchTreePanel/RepoObjectsTree.Nodes.cs Outdated Show resolved Hide resolved
GitUI/BranchTreePanel/RepoObjectsTree.Nodes.cs Outdated Show resolved Hide resolved
@gerhardol gerhardol force-pushed the feature/p9864-side-filter-change branch from 4231261 to 15c67e6 Compare March 15, 2022 22:13
@gerhardol gerhardol merged commit 2b1ef6c into gitextensions:master Mar 15, 2022
@ghost ghost added this to the vNext milestone Mar 15, 2022
@gerhardol gerhardol deleted the feature/p9864-side-filter-change branch March 15, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants