Browse: Clarify RefreshRevisions() handling #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new repo is opened in FormBrowse the call chain is SetGitModule() -> UICommands_PostRepositoryChanged() -> RefreshRevisions() Most other refreshes in Browse uses RepoChangedNotifier.Notify(), which is confusing when reading the code. As the sidepanel is init from RepoChangedNotifier.Notify(), the use of Notify() cannot be changed now. This commit just separates the changes to RefreshRevisions().
ghost
assigned 
RussKie
approved these changes
Mar 14, 2022
mstv
approved these changes
Mar 14, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9864, related to #9888
Proposed changes
If a new repo is opened in FormBrowse the call chain is
SetGitModule() -> UICommands_PostRepositoryChanged() -> RefreshRevisions()
Most other refreshes in Browse uses RepoChangedNotifier.Notify(),
which is confusing when reading the code.
As the sidepanel is init from RepoChangedNotifier.Notify(),
the use of Notify() cannot be changed now.
This commit just separates the changes to RefreshRevisions().
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.