New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ShortcutKeys
Ctrl+F
with Hotkeys
#9931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a name change
There are some assignments of ShortcutKeys still, also RevDiff and Browse...
Review comment: Rename to Command.FindFile
No default hotkey for RevisionDiffControl.Command.FindFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We just need to add auto-focus for the File Tree control:
diff --git a/GitUI/CommandsDialogs/FormBrowse.cs b/GitUI/CommandsDialogs/FormBrowse.cs
index 9f10dddd3..726e10e26 100644
--- a/GitUI/CommandsDialogs/FormBrowse.cs
+++ b/GitUI/CommandsDialogs/FormBrowse.cs
@@ -1549,6 +1549,10 @@ private void CommitInfoTabControl_SelectedIndexChanged(object sender, EventArgs
// workaround to avoid focusing the "filter files" combobox
revisionDiff.SwitchFocus(alreadyContainedFocus: false);
}
+ else if (CommitInfoTabControl.SelectedTab == TreeTabPage)
+ {
+ fileTree.SwitchFocus(alreadyContainedFocus: false);
+ }
}
👍 Ready for squash-merge. |
Go for it :)
|
Fixes #9921
Proposed changes
ShortcutKeys
Ctrl+F
with HotkeysScreenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.