Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitInfo: Clear RevisionInfo if no real revision #9933

Merged
merged 1 commit into from Apr 4, 2022

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 2, 2022

Proposed changes

  • For artificial commits, clear the lower panel of the CommitInfo

Screenshots

Before

grafik

After

grafik

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build b841ac9
  • Git 2.35.1.windows.1
  • Microsoft Windows NT 10.0.19044.0
  • .NET 5.0.12
  • DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv added the type: regression regression, normally to latest official release label Apr 2, 2022
@mstv mstv self-assigned this Apr 2, 2022
@gerhardol
Copy link
Member

I think this is good info also for artificial commits

@mstv
Copy link
Member Author

mstv commented Apr 3, 2022

I think this is good info also for artificial commits

I guess you mean to display the info of the current checkout. Then the CommitInfo must be updated accordingly.
Though "Contained in" cannot really be true for artificial commits.
(The empty space might be filled with an edit field for the commit message in the future.)

Currently, it shows the info for the previously selected commit, which can be totally unrelated, i.e. wrong.

@RussKie RussKie merged commit 1bc3bb9 into gitextensions:master Apr 4, 2022
@ghost ghost added this to the vNext milestone Apr 4, 2022
@mstv mstv deleted the fix/artificial_commit_info branch April 6, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression regression, normally to latest official release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants