New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormResolveConflicts: Clearer label and confirmation messages for Reset button #9942
Conversation
|
||
private readonly TranslationString _abortCurrentOperationCaption = new("Abort"); | ||
private readonly TranslationString _resetCaption = new("Reset changes"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor preference for just Reset, but that may not be clearer...
I was and am undecided. |
I find |
I think a fix would mean the dialog's updated to inherit from [EDIT] On a second thought, "All buttons" may be a stretch - some buttons may be "context dependent" and as such won't belong to the footer of the dialog. |
OK, done.
A tooltip would be a good idea. But the designer is broken. It is not worth fixing it right now. I think the updated label and message suffice.
Already there. |
Replaces #9907, which would be too intrusive and does not work for cherry-picks
Proposed changes
Reset
button(The command
git reset --hard
will still be used.)Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.