Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormResolveConflicts: Clearer label and confirmation messages for Reset button #9942

Merged
merged 2 commits into from Jun 2, 2022

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 6, 2022

Replaces #9907, which would be too intrusive and does not work for cherry-picks

Proposed changes

  • FormResolveConflicts: Just clearer label and confirmation messages for Reset button
    (The command git reset --hard will still be used.)

Screenshots

Before

image

After

image

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build ec324af
  • Git 2.35.1.windows.1
  • Microsoft Windows NT 10.0.19044.0
  • .NET 6.0.3
  • DPI 96dpi (no scaling)

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Apr 6, 2022

private readonly TranslationString _abortCurrentOperationCaption = new("Abort");
private readonly TranslationString _resetCaption = new("Reset changes");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor preference for just Reset, but that may not be clearer...

@RussKie
Copy link
Member

RussKie commented Apr 16, 2022

grafik

The new button text is clipped.

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Apr 16, 2022
@ghost ghost added the 💤 status: no recent activity The issue is stale label May 16, 2022
@mstv
Copy link
Member Author

mstv commented May 23, 2022

Popup title: I have a minor preference for just Reset, but that may not be clearer...

The new button text is clipped.

I was and am undecided.
Would "Reset to previous" suffice for the button? Or even just "Reset"?
Or should I resize the buttons (with some reserve for lengthy translations)?

@ghost ghost removed 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity 💤 status: no recent activity The issue is stale labels May 23, 2022
@gitextensions gitextensions deleted a comment May 23, 2022
@gerhardol
Copy link
Member

I was and am undecided. Would "Reset to previous" suffice for the button? Or even just "Reset"? Or should I resize the buttons (with some reserve for lengthy translations)?

I find Reset enough, easier to translate and full info in the popup.
(Maybe tooltip)

@RussKie
Copy link
Member

RussKie commented May 24, 2022

I think a fix would mean the dialog's updated to inherit from GitExtensionsDialog and all the buttons moved to ControlsPanel (see #6183). This way the buttons can have arbitrary widths. Though I agree that it doesn't mean that we'd want the buttons to contain more text than absolutely necessary. Tooltips can be used to provide extra data. Also each form can/should point to the relevant section in the docs, which should/can contain all the necessary information pertaining to the dialog and individual elements on it.

[EDIT] On a second thought, "All buttons" may be a stretch - some buttons may be "context dependent" and as such won't belong to the footer of the dialog.

@mstv
Copy link
Member Author

mstv commented May 24, 2022

I find Reset enough, easier to translate and full info in the popup.

OK, done.

(Maybe tooltip)

Tooltips can be used to provide extra data.

A tooltip would be a good idea. But the designer is broken. It is not worth fixing it right now. I think the updated label and message suffice.

I think a fix would mean the dialog's updated to inherit from GitExtensionsDialog and all the buttons moved to ControlsPanel (see #6183). This way the buttons can have arbitrary widths. Though I agree that it doesn't mean that we'd want the buttons to contain more text than absolutely necessary.

category: nice to have Not my cup of tea, anyway.

Also each form can/should point to the relevant section in the docs, which should/can contain all the necessary information pertaining to the dialog and individual elements on it.

Already there.

@mstv mstv merged commit 9168654 into gitextensions:master Jun 2, 2022
@ghost ghost added this to the vNext milestone Jun 2, 2022
@mstv mstv deleted the feature/9575_reset_conflicts branch June 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants