Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel: split up large code files #9967

Merged

Conversation

h0lg
Copy link
Contributor

@h0lg h0lg commented Apr 17, 2022

This PR doesn't change functionality but merely moves some classes into separate files.
This was requested by @mstv and @RussKie in #9723 but not done in that PR to make reviewing its changes easier.

I agree that the maintainer squash merge this PR (if the commit message is clear). Note though that if you squash merge, git won't be able to track the move for the file history.


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned h0lg Apr 17, 2022
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks like you've taken a long path. It's much easier to use VS quick actions:
image

@RussKie RussKie merged commit 7cd090f into gitextensions:master Apr 18, 2022
@ghost ghost added this to the vNext milestone Apr 18, 2022
@h0lg
Copy link
Contributor Author

h0lg commented Apr 19, 2022

@RussKie I'm fully aware of that feature, thanks :) I explicitly ignored it in favor of making manual copies so that git would follow the move of the type without creating a hard break in the file history.

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@h0lg h0lg deleted the left-panel/split-up-large-code-files branch April 22, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants