-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#54: Add basic CI/CD for projects #84
#54: Add basic CI/CD for projects #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great job @EddieEldridge, thanks!
And once @gitfrosh enables GitHub actions, we can test it and fix if something’s not working.
.github/workflows/build.yml
Outdated
# Run react-scripts tests | ||
# Note: There are currently no tests | ||
# - name: Install Dependencies | ||
# working-directory: ./backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe working-directory should be ./frontend, right ? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe working-directory should be ./frontend, right ? 🙂
Fixed! Thank you!
Hey y'all, I think it's already enabled?: Feel free to make tests and play around with the setup! Unfortunately, I don't have the time to look into this matter right now, but it would be a great improvement for the project. @EddieEldridge, would you like to have this PR approved for hacktoberfest? |
Thanks for checking, I figured it out, it actually runs on my fork rather than here which makes sense. Looks like it needs some more configuration as the tests are failing -> https://github.com/EddieEldridge/lotr-api/actions/runs/3338861352/jobs/5527069456 As this isn't quite ready yet, I'm going to close this and re-open it when it is. |
https://github.com/EddieEldridge/lotr-api/actions/runs/3345373488 And yes @gitfrosh , you can tag this with #Hacktoberfest! It looks cool! |
#54
This adds the following functionality
backend
and runs the testsfrontend
sample-app
and creates a buildbackend
@gitfrosh I haven't been able to test this as of yet, as I believe you may need to enable Actions in the settings.