Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#54: Add basic CI/CD for projects #84

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

EddieEldridge
Copy link
Contributor

@EddieEldridge EddieEldridge commented Oct 25, 2022

#54

This adds the following functionality

  • Displays a Sponsor badge on the GitHub Page
  • Installs the deps. for the backend and runs the tests
  • Installs the deps. for the frontend
  • Installs the deps. for the sample-app and creates a build
  • Adds the missing package-lock.json from the backend
  • Sets up the framework for doing an automatic release/deploy if needed

@gitfrosh I haven't been able to test this as of yet, as I believe you may need to enable Actions in the settings.

Copy link
Collaborator

@MateuszKikmunter MateuszKikmunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great job @EddieEldridge, thanks!
And once @gitfrosh enables GitHub actions, we can test it and fix if something’s not working.

# Run react-scripts tests
# Note: There are currently no tests
# - name: Install Dependencies
# working-directory: ./backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe working-directory should be ./frontend, right ? 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe working-directory should be ./frontend, right ? 🙂

Fixed! Thank you!

@gitfrosh
Copy link
Owner

Hey y'all, I think it's already enabled?:

image

Feel free to make tests and play around with the setup! Unfortunately, I don't have the time to look into this matter right now, but it would be a great improvement for the project.

@EddieEldridge, would you like to have this PR approved for hacktoberfest?

@EddieEldridge
Copy link
Contributor Author

EddieEldridge commented Oct 27, 2022

Hey y'all, I think it's already enabled?:

image

Feel free to make tests and play around with the setup! Unfortunately, I don't have the time to look into this matter right now, but it would be a great improvement for the project.

@EddieEldridge, would you like to have this PR approved for hacktoberfest?

Thanks for checking, I figured it out, it actually runs on my fork rather than here which makes sense. Looks like it needs some more configuration as the tests are failing -> https://github.com/EddieEldridge/lotr-api/actions/runs/3338861352/jobs/5527069456

As this isn't quite ready yet, I'm going to close this and re-open it when it is.

@EddieEldridge EddieEldridge reopened this Oct 28, 2022
@EddieEldridge
Copy link
Contributor Author

EddieEldridge commented Oct 28, 2022

https://github.com/EddieEldridge/lotr-api/actions/runs/3345373488
Successful run!

And yes @gitfrosh , you can tag this with #Hacktoberfest! It looks cool!

@gitfrosh gitfrosh merged commit 467cd12 into gitfrosh:release Dec 2, 2022
@gitfrosh gitfrosh linked an issue Dec 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a basic CI/CD pipeline
3 participants