Skip to content

Commit

Permalink
parse-options: format argh like error messages
Browse files Browse the repository at this point in the history
"Keep it homogeneous across the repository" is in general a
guideline that can be used to converge to a good practice, but
we can be a bit more prescriptive in this case.  Just like the
messages we give die(_("...")) are formatted without the final
full stop and without the initial capitalization, most of the
argument help text are already formatted that way, and we want
to encourage that as the house style.

Noticed-by: ZheNing Hu <adlternative@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
gitster authored and adlternative committed Jan 6, 2021
1 parent 52f7c84 commit c5f01b0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions parse-options.h
Expand Up @@ -82,9 +82,9 @@ typedef enum parse_opt_result parse_opt_ll_cb(struct parse_opt_ctx_t *ctx,
* stores pointers to the values to be filled.
*
* `argh`::
* token to explain the kind of argument this option wants. Keep it
* homogeneous across the repository. Should be wrapped by N_() for
* translation.
* token to explain the kind of argument this option wants. Does not
* begin in capital letter, and does not end with a full stop.
* Should be wrapped by N_() for translation.
*
* `help`::
* the short help associated to what the option does.
Expand Down

0 comments on commit c5f01b0

Please sign in to comment.