Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reverse_commit_list() in more places #1156

Closed
dscho opened this issue Feb 22, 2022 · 3 comments
Closed

Use reverse_commit_list() in more places #1156

dscho opened this issue Feb 22, 2022 · 3 comments
Labels
good first issue Good for newcomers leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits

Comments

@dscho
Copy link
Member

dscho commented Feb 22, 2022

From https://lore.kernel.org/git/CABPp-BESAh6wLComJoYsf7Q7NF2EMPptKRhfAoy=1-ZRZovnaQ@mail.gmail.com/:

[...] we could also [... use reverse_commit_list() in ...] the code snippets in builtin/merge.c and sequencer.c that you can find with

git grep commit_list_insert.*reversed
@dscho dscho added leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits good first issue Good for newcomers labels Feb 22, 2022
@victorphoenix3
Copy link

Hi, I am new to the community. May I submit a patch for this issue?

@dscho
Copy link
Member Author

dscho commented Mar 12, 2022

Yes! You don't even need anyone's permission for that 😁

@victorphoenix3 victorphoenix3 mentioned this issue Mar 15, 2022
Closed
@newren
Copy link

newren commented Feb 3, 2023

This was implemented last year (see thread at https://lore.kernel.org/git/CANsrJQd0v2V9H8HPkiH2179C1c-NOSTRRB8YXt8v6R0YAbFPDQ@mail.gmail.com).

Closing now.

@newren newren closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dscho @newren @victorphoenix3