t/README: fix typo

[mstrap]

cc: Johannes Schindelin Johannes.Schindelin@gmx.de

[mstrap]

/submit

[gitgitgadget]

Submitted as pull.1110.git.1641338224631.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1

To fetch this version to local tag pr-1110/mstrap/feature/README-typo-v1:

git fetch --no-tags https://github.com/gitgitgadget/git tag pr-1110/mstrap/feature/README-typo-v1

[gitgitgadget]

This branch is now known as ms/t-readme-typofix.

[gitgitgadget]

This patch series was integrated into seen via git@e40ab7d.

[gitgitgadget]

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Marc,

On Tue, 4 Jan 2022, Marc Strapetz via GitGitGadget wrote:

> From: Marc Strapetz <marc.strapetz@syntevo.com>
>
> Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>
> ---
>     t/README: fix typo
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1110
>
>  t/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/README b/t/README
> index 2353a4c5e13..f48e0542cdc 100644
> --- a/t/README
> +++ b/t/README
> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
>  complete or needs to be abandoned for whatever reason (in which case the
>  migrated codepaths still retain their performance benefits).
>
> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of

Good find!

I'm curious, how did you find it? If it was a spell checker, did it also
find the "dotsh" typo in the same file (it should be "dots", I think)?

Ciao,
Dscho

>  prereqs that are required to succeed. If a prereq in this list is triggered by
>  a test and then fails then the whole test run will abort. This can help to make
>  sure the expected tests are executed and not silently skipped when their
>
> base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
> --
> gitgitgadget
>

[gitgitgadget]

User Johannes Schindelin <Johannes.Schindelin@gmx.de> has been added to the cc: list.

[gitgitgadget]

On the Git mailing list, Marc Strapetz wrote (reply to this):

Hi Dscho,

On 05/01/2022 17:22, Johannes Schindelin wrote:
>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
>>   complete or needs to be abandoned for whatever reason (in which case the
>>   migrated codepaths still retain their performance benefits).
>>
>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
> 
> Good find!
> 
> I'm curious, how did you find it? If it was a spell checker, did it also

I found it by plain reading :) as I had troubles to get a test working.

 > find the "dotsh" typo in the same file (it should be "dots", I think)?

I wouldn't have noticed that, but I agree that it should be 
"test_name_without_dots".

-Marc

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Marc Strapetz via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of

Thanks, queued.

[gitgitgadget]

This patch series was integrated into seen via git@5770a72.

[gitgitgadget]

This patch series was integrated into seen via git@a4ed545.

[gitgitgadget]

There was a status update in the "New Topics" section about the branch ms/t-readme-typofix on the Git mailing list:

Typofix.

Will merge to 'next'.
source: <pull.1110.git.1641338224631.gitgitgadget@gmail.com>

[gitgitgadget]

On the Git mailing list, Marc Strapetz wrote (reply to this):

On 05/01/2022 17:47, Marc Strapetz wrote:
> Hi Dscho,
> 
> On 05/01/2022 17:22, Johannes Schindelin wrote:
>>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing 
>>> submodule objects is
>>>   complete or needs to be abandoned for whatever reason (in which 
>>> case the
>>>   migrated codepaths still retain their performance benefits).
>>>
>>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated 
>>> list of
>>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated 
>>> list of
>>
>> Good find!
>>
>> I'm curious, how did you find it? If it was a spell checker, did it also
> 
> I found it by plain reading :) as I had troubles to get a test working.
> 
>  > find the "dotsh" typo in the same file (it should be "dots", I think)?
> 
> I wouldn't have noticed that, but I agree that it should be 
> "test_name_without_dots".

Please disregard my last statement. "test_name_without_dotsh" means 
"test name without .sh extension". For 
"t2109-update-index-index-version.sh", the directory will be "trash 
directory.t2109-update-index-index-version".

-Marc

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

Marc Strapetz <marc.strapetz@syntevo.com> writes:

>>  > find the "dotsh" typo in the same file (it should be "dots", I
>> think)?
>> I wouldn't have noticed that, but I agree that it should be 
>> "test_name_without_dots".
>
> Please disregard my last statement. "test_name_without_dotsh" means
> "test name without .sh extension". For 
> "t2109-update-index-index-version.sh", the directory will be "trash
> directory.t2109-update-index-index-version".

Yup.  "without_dot_sh" might have been a better way to spell it, but
"without_dotsh" certainly is better than "without_dots".

Thanks for being extra careful.  In any case, the original fix is
good and has already been queued.

[gitgitgadget]

This patch series was integrated into seen via git@9cc3d93.

[gitgitgadget]

This patch series was integrated into next via git@59288eb.

[gitgitgadget]

This patch series was integrated into seen via git@27a70fa.

[gitgitgadget]

This patch series was integrated into next via git@27a70fa.

[gitgitgadget]

This patch series was integrated into master via git@27a70fa.

[gitgitgadget]

Closed via 27a70fa.