object-file: pass filename to fsync_or_die

[neerajsi-msft]

If we die while trying to fsync a loose object file, pass the actual
filename we're trying to sync. This is likely to be more helpful for a
user trying to diagnose the cause of the failure than the former
'loose object file' string. It also sidesteps any concerns about
translating the die message differently for loose objects versus
something else that has a real path.

Reported-by: Ævar Arnfjörð Bjarmason avarab@gmail.com
Signed-off-by: Neeraj Singh neerajsi@microsoft.com

This is in response to:
https://lore.kernel.org/git/220321.861qyv9rjr.gmgdl@evledraar.gmail.com/

Unrelated nit: this API is producing sentence lego unfriendly to translators.

[neerajsi-msft]

/submit

[gitgitgadget]

Submitted as pull.1194.git.1648664055986.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1194/neerajsi-msft/ns/fsync-die-filename-v1

To fetch this version to local tag pr-1194/neerajsi-msft/ns/fsync-die-filename-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1194/neerajsi-msft/ns/fsync-die-filename-v1

[gitgitgadget]

This branch is now known as ns/fsync-or-die-message-fix.

[gitgitgadget]

This patch series was integrated into seen via git@1c2d173.

[gitgitgadget]

There was a status update in the "New Topics" section about the branch ns/fsync-or-die-message-fix on the Git mailing list:

When creating a loose object file, we didn't report the exact
filename of the file we failed to fsync, even though the
information was readily available, which has been corrected.

Will merge to 'next'.
source: <pull.1194.git.1648664055986.gitgitgadget@gmail.com>

[gitgitgadget]

This patch series was integrated into seen via git@26d1013.

[gitgitgadget]

This patch series was integrated into next via git@9de1909.

[gitgitgadget]

This patch series was integrated into seen via git@656a3cf.

[gitgitgadget]

This patch series was integrated into seen via git@7f77b4d.

[gitgitgadget]

This patch series was integrated into seen via git@98f6a3a.

[gitgitgadget]

This patch series was integrated into master via git@98f6a3a.

[gitgitgadget]

This patch series was integrated into next via git@98f6a3a.

[gitgitgadget]

Closed via 98f6a3a.