-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC][Patch] area: t4202-log.sh, modernizing test script #1220
base: master
Are you sure you want to change the base?
Conversation
Replace test body spaces with tabs where appropiate Remove blank lines at start and and of test bodies. Signed-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>
Remove whitespace after redirect operator. Signed-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>
Split up multiple lines on one line to multiple Fix style of cd & echo in subshell Signed-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>
/preview |
Preview email sent as pull.1220.git.1650328292.gitgitgadget@gmail.com |
/submit |
Submitted as pull.1220.git.1650331876.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
Hi @JackMcGu: You can force-push to your topic and re-submit from the same PR. This allows GitGitGadget to realize you have a new version, then show a range-diff between the versions. It keeps the topic threaded nicely on the mailing list, too. (Oh, and it adds CCs for the reviewers you've had so far.) |
On the Git mailing list, Bagas Sanjaya wrote (reply to this):
|
User |
On the Git mailing list, Jack McGuinness wrote (reply to this):
|
User |
On the Git mailing list, Christian Couder wrote (reply to this):
|
User |
I am using this thread to redo my previous attempt to modernize, where I mistakenly replaced spaces with tabs incorrectly, and to complete the rest of the modernization of t4202.
I am really new to gitgitgadget, and contributing to open source in general, so I expect I will mess up again, but hopefully I can get manage to get through it when i do.
Thank you Derrick Stolee for reviewing my last patch, it's clear I still have a lot of work to do on understanding style and bash scripting.
Thanks for checking this,
-Jack McGuinness jmcguinness2@ucmerced.edu
cc: Bagas Sanjaya bagasdotme@gmail.com
cc: Jack McGuinness jmcguinness2@ucmerced.edu
cc: Christian Couder christian.couder@gmail.com