Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls-files: fix black space in error message #1350

Conversation

adlternative
Copy link

@adlternative adlternative commented Sep 11, 2022

This patch want fix a little typo error in builtin/ls-files.c,
which pointed out by Jiang Xin in [1].

[1]: https://lore.kernel.org/git/CANYiYbFGSfg+iFV1ovhCSxW0YQSpemKUN-sS+F0BHee7KD5arA@mail.gmail.com/.

cc: Junio C Hamano gitster@pobox.com
cc: Jiang Xin worldhello.net@gmail.com

ce74de9(ls-files: introduce "--format" option) miss
a space between two words incorrectly, it leads to
wrong i10n messages. So fix it by adding a space at
the end of the error message.

Signed-off-by: ZheNing Hu <adlternative@gmail.com>
@adlternative
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 11, 2022

Submitted as pull.1350.git.1662904997760.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1

To fetch this version to local tag pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

On the Git mailing list, Junio C Hamano wrote (reply to this):

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: ZheNing Hu <adlternative@gmail.com>
> Subject: Re: [PATCH] ls-files: fix black space in error message

"black" -> "missing" perhaps?  I'll queue with the reword for now
but if you have a better alternative please holler.

> ce74de9(ls-files: introduce "--format" option) miss a space
> between two words incorrectly, it leads to wrong i10n messages. So
> fix it by adding a space at the end of the error message.

Thanks.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

This branch is now known as zh/ls-files-format.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

This patch series was integrated into seen via git@dd99408.

@gitgitgadget gitgitgadget bot added the seen label Sep 12, 2022
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

This patch series was integrated into seen via git@bbd2d6d.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

This patch series was integrated into next via git@91dda58.

@gitgitgadget gitgitgadget bot added the next label Sep 12, 2022
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 12, 2022

This patch series was integrated into seen via git@caad3f4.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 13, 2022

This patch series was integrated into seen via git@b344efd.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 13, 2022

This patch series was integrated into seen via git@036ba82.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 13, 2022

This patch series was integrated into seen via git@fc6d361.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 14, 2022

There was a status update in the "New Topics" section about the branch zh/ls-files-format on the Git mailing list:

Typofix in the UI of a topic that has graduated to 'master'.

Will merge to 'master'.
source: <pull.1350.git.1662904997760.gitgitgadget@gmail.com>

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 15, 2022

This patch series was integrated into seen via git@e79c03d.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 15, 2022

This patch series was integrated into seen via git@d8c98a1.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 16, 2022

There was a status update in the "Cooking" section about the branch zh/ls-files-format on the Git mailing list:

Typofix in the UI of a topic that has graduated to 'master'.

Will merge to 'master'.
source: <pull.1350.git.1662904997760.gitgitgadget@gmail.com>

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 17, 2022

On the Git mailing list, ZheNing Hu wrote (reply to this):

Junio C Hamano <gitster@pobox.com> 于2022年9月13日周二 00:24写道:
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: ZheNing Hu <adlternative@gmail.com>
> > Subject: Re: [PATCH] ls-files: fix black space in error message
>
> "black" -> "missing" perhaps?  I'll queue with the reword for now
> but if you have a better alternative please holler.
>

Use the "missing" is ok, thanks,

> > ce74de9(ls-files: introduce "--format" option) miss a space
> > between two words incorrectly, it leads to wrong i10n messages. So
> > fix it by adding a space at the end of the error message.
>
> Thanks.

ZheNing Hu

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 19, 2022

This patch series was integrated into seen via git@f876b5a.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 19, 2022

This patch series was integrated into master via git@f876b5a.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 19, 2022

This patch series was integrated into next via git@f876b5a.

@gitgitgadget gitgitgadget bot added the master label Sep 19, 2022
@gitgitgadget gitgitgadget bot closed this Sep 19, 2022
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 19, 2022

Closed via f876b5a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant