New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ls-files: fix black space in error message #1350
ls-files: fix black space in error message #1350
Conversation
ce74de9(ls-files: introduce "--format" option) miss a space between two words incorrectly, it leads to wrong i10n messages. So fix it by adding a space at the end of the error message. Signed-off-by: ZheNing Hu <adlternative@gmail.com>
/submit |
Submitted as pull.1350.git.1662904997760.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Junio C Hamano wrote (reply to this): "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: ZheNing Hu <adlternative@gmail.com>
> Subject: Re: [PATCH] ls-files: fix black space in error message
"black" -> "missing" perhaps? I'll queue with the reword for now
but if you have a better alternative please holler.
> ce74de9(ls-files: introduce "--format" option) miss a space
> between two words incorrectly, it leads to wrong i10n messages. So
> fix it by adding a space at the end of the error message.
Thanks. |
This branch is now known as |
This patch series was integrated into seen via git@dd99408. |
This patch series was integrated into seen via git@bbd2d6d. |
This patch series was integrated into next via git@91dda58. |
This patch series was integrated into seen via git@caad3f4. |
This patch series was integrated into seen via git@b344efd. |
This patch series was integrated into seen via git@036ba82. |
This patch series was integrated into seen via git@fc6d361. |
There was a status update in the "New Topics" section about the branch Typofix in the UI of a topic that has graduated to 'master'. Will merge to 'master'. source: <pull.1350.git.1662904997760.gitgitgadget@gmail.com> |
This patch series was integrated into seen via git@e79c03d. |
This patch series was integrated into seen via git@d8c98a1. |
There was a status update in the "Cooking" section about the branch Typofix in the UI of a topic that has graduated to 'master'. Will merge to 'master'. source: <pull.1350.git.1662904997760.gitgitgadget@gmail.com> |
On the Git mailing list, ZheNing Hu wrote (reply to this): Junio C Hamano <gitster@pobox.com> 于2022年9月13日周二 00:24写道:
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: ZheNing Hu <adlternative@gmail.com>
> > Subject: Re: [PATCH] ls-files: fix black space in error message
>
> "black" -> "missing" perhaps? I'll queue with the reword for now
> but if you have a better alternative please holler.
>
Use the "missing" is ok, thanks,
> > ce74de9(ls-files: introduce "--format" option) miss a space
> > between two words incorrectly, it leads to wrong i10n messages. So
> > fix it by adding a space at the end of the error message.
>
> Thanks.
ZheNing Hu |
This patch series was integrated into seen via git@f876b5a. |
This patch series was integrated into master via git@f876b5a. |
This patch series was integrated into next via git@f876b5a. |
Closed via f876b5a. |
This patch want fix a little typo error in builtin/ls-files.c,
which pointed out by Jiang Xin in [1].
[1]: https://lore.kernel.org/git/CANYiYbFGSfg+iFV1ovhCSxW0YQSpemKUN-sS+F0BHee7KD5arA@mail.gmail.com/.
cc: Junio C Hamano gitster@pobox.com
cc: Jiang Xin worldhello.net@gmail.com