Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf/fsmonitor: use test_must_be_empty helper #799

Closed

Conversation

nipunn1313
Copy link

@nipunn1313 nipunn1313 commented Nov 25, 2020

Simplify perf/fsmonitor test and make error messages more clear.

cc: Derrick Stolee stolee@gmail.com

Simplify test and make error messages more clear here.
Per feedback from Junio in
33226af (t/perf/fsmonitor: improve error message if typoing hook
name, 2020-10-26)

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
@nipunn1313
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 25, 2020

Submitted as pull.799.git.1606342297403.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1

To fetch this version to local tag pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1:

git fetch --no-tags https://github.com/gitgitgadget/git tag pr-799/nipunn1313/nk/fsmonitor-test-cleanup-v1

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 30, 2020

On the Git mailing list, Derrick Stolee wrote (reply to this):

On 11/25/2020 5:11 PM, Nipunn Koorapati via GitGitGadget wrote:
> From: Nipunn Koorapati <nipunn@dropbox.com>
> 
> Simplify test and make error messages more clear here.
> Per feedback from Junio in
> 33226af42b (t/perf/fsmonitor: improve error message if typoing hook
> name, 2020-10-26)

Thanks, Nipunn. This patch looks good to me.

-Stolee

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 30, 2020

User Derrick Stolee <stolee@gmail.com> has been added to the cc: list.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 1, 2020

This branch is now known as nk/perf-fsmonitor-cleanup.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 1, 2020

This patch series was integrated into seen via git@272b55c.

@gitgitgadget gitgitgadget bot added the seen label Dec 1, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Dec 1, 2020

This patch series was integrated into seen via git@4ae8792.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 2, 2020

This patch series was integrated into seen via git@e75294e.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 3, 2020

This patch series was integrated into seen via git@e229b6a.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 3, 2020

This patch series was integrated into next via git@3096e95.

@gitgitgadget gitgitgadget bot added the next label Dec 3, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Dec 9, 2020

This patch series was integrated into seen via git@8e2def7.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 9, 2020

This patch series was integrated into next via git@8e2def7.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 9, 2020

This patch series was integrated into master via git@8e2def7.

@gitgitgadget gitgitgadget bot added the master label Dec 9, 2020
@gitgitgadget gitgitgadget bot closed this Dec 9, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Dec 9, 2020

Closed via 8e2def7.

@nipunn1313 nipunn1313 deleted the nk/fsmonitor-test-cleanup branch January 14, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant