New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for-each-repo: do nothing on empty config #834
for-each-repo: do nothing on empty config #834
Conversation
/submit |
Submitted as pull.834.git.1609857770445.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
User |
36dccbb
to
970d37f
Compare
On the Git mailing list, Derrick Stolee wrote (reply to this):
|
User |
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Derrick Stolee wrote (reply to this):
|
On the Git mailing list, Derrick Stolee wrote (reply to this):
|
970d37f
to
a1f1300
Compare
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
/submit |
Submitted as pull.834.v2.git.1609960783988.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
This branch is now known as |
This patch series was integrated into seen via git@c20da23. |
On the Git mailing list, Derrick Stolee wrote (reply to this):
|
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
This patch series was integrated into seen via git@21c5d0e. |
This patch series was integrated into seen via git@0932688. |
This patch series was integrated into seen via git@b794997. |
'git for-each-repo --config=X' should return success without calling any subcommands when the config key 'X' has no value. The current implementation instead segfaults. A user could run into this issue if they used 'git maintenance start' to initialize their cron schedule using 'git for-each-repo --config=maintenance.repo ...' but then using 'git maintenance unregister' to remove the config option. (Note: 'git maintenance stop' would remove the config _and_ remove the cron schedule.) Add a simple test to ensure this works. Use 'git help --no-such-option' as the potential subcommand to ensure that we will hit a failure if the subcommand is ever run. Reported-by: Andreas Bühmann <dev@uuml.de> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
a1f1300
to
31350c7
Compare
This patch series was integrated into seen via git@93f2f03. |
/submit |
Submitted as pull.834.v3.git.1610073047135.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
This patch series was integrated into seen via git@70f5487. |
This patch series was integrated into seen via git@4874050. |
This patch series was integrated into seen via git@6ba4b42. |
This patch series was integrated into seen via git@bcb7c6f. |
This patch series was integrated into seen via git@5b1463b. |
This patch series was integrated into seen via git@92f83b5. |
This patch series was integrated into seen via git@7b56713. |
This patch series was integrated into next via git@92f83b5. |
Closing due to landing in |
Thanks, Andreas, for drawing my attention to this bug.
V3: update comment in test and use
git help --no-such-option
as the subcommand to fail.[1] #833
cc: gitster@pobox.com
cc: Eric Sunshine sunshine@sunshineco.com
cc: Derrick Stolee stolee@gmail.com