[GSOC] commit: add own-identity option #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, Git has supported the 'Signed-off-by' commit trailer using the '--signoff' and the '-s' option from the command line. But users may need to provide other trailer information from the command line such as "Helped-by", "Reported-by", "Mentored-by", Now implement a new `--trailer <token>[(=|:)<value>]` option to pass other trailers to `interpret-trailers` and insert them into commit messages. Signed-off-by: ZheNing Hu <adlternative@gmail.com>
`git commit --trailer="Signed-off-by: \ $(git config user.name) <$(git config user.email)>"` is difficult for users to add their own identities, so teach interpret-trailers a new option `--own-identity` which allow if we're optionalise <value> in `--trailer`, by substitute user's identity if missing. This will help the use of `commit --trailer` as easy as `commit --signoff`. Signed-off-by: ZheNing Hu <adlternative@gmail.com>
Use the newly added option `--own-identity` in `interpret-trailers`, implement new commit option `--own-identity` to allow user optionalise <value> in `--trailer`, by substitute user's identity if missing. Using the `--own-identity` option, users can directly use `--trailer="Signed-off-by"` to generate a signoff trailer with their own identities in commit messages, The effect is basically the same as the `--signoff` option. However, users can add more useful options at the same time. e.g. `--trailer="Helped-by" --own-identity` can general `Helped-by: C O Mitter <committer@example.com>`, or through appropriate configuration: `git -c trailer.signoff.key="Signed-off-by" commit \ --trailer="signoff" --own-identity` can also general their needs trailers with their favorite keys and their own identities. Signed-off-by: ZheNing Hu <adlternative@gmail.com>
adlternative
changed the title
|
/submit |
|
Submitted as pull.909.git.1616155599.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series is the basis for
commit --trailerin #901and provides
--own-identityoption for--trailer.Junio's suggestion is that we can provide
--trailer="@SomeOne"in the later stages to support filling multiple identities which obtain
from
git log.cc: Bradley M. Kuhn bkuhn@sfconservancy.org
cc: Junio C Hamano gitster@pobox.com
cc: Brandon Casey drafnel@gmail.com
cc: Shourya Shukla periperidip@gmail.com
cc: Christian Couder christian.couder@gmail.com
cc: Rafael Silva rafaeloliveira.cs@gmail.com
cc: Đoàn Trần Công Danh congdanhqx@gmail.com