Skip to content

pr-1022/phil-blain/test-pause-and-debug-easier-v1

pr-1022/phil-blain/test-pause-and-debug-easier-v1: test-lib-functions.sh: keep user's HOME, TERM and SHELL for 'test_pau…
tagged this 19 Aug 17:16 
…se' and 'debug'

This series proposes two small quality-of-life improvements (in my opinion)
to the 'test_pause' and 'debug' test functions: using the original values of
HOME and TERM (before they are changed by the test framework) and using
SHELL instead of SHELL_PATH.

The later might be too big of a change, but I think it makes sense. We could
add a new GIT_TEST_* to conditionnaly change the behaviour, but I kept it
simple for v1.

Cheers, Philippe.

Philippe Blain (2):
  test-lib-functions: use user's SHELL, HOME and TERM for 'test_pause'
  test-lib-functions: use user's TERM and HOME for 'debug'

 t/test-lib-functions.sh | 4 ++--
 t/test-lib.sh           | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf

Submitted-As: https://lore.kernel.org/git/pull.1022.git.1629393395.gitgitgadget@gmail.com
Assets 2