Skip to content

pr-1086/jamesl-dm/maint-v3

From: James Limbouris <james@digitalmatter.com>

check_parents was taking all of its arguments as a single string,
and erroneously passing them to cache_miss as a single string. For
commits with a single parent this would succeed, but whenever a merge
commit was processed, cache_miss would be passed "parent1 parent2"
instead of "parent1" "parent2" and fail, leading to unecessary rechecks
of the parent commits.

For consistency, take multiple arguments in check_parents,
and pass all of them to cache_miss separately.

Signed-off-by: James Limbouris <james@digitalmatter.com>

Submitted-As: https://lore.kernel.org/git/pull.1086.v3.git.1638758742741.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1086.git.1638324413653.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1086.v2.git.1638424290015.gitgitgadget@gmail.com
Assets 2