pr-112/derrickstolee/graph/v2-head-v5
tagged this
12 Jun 13:29
This series replaces ds/commit-graph-file-v2, and I'm using the same gitgitgadget PR to continue the version numbers and hopefully make that clear. This is a slight modification on patches 1-11 from the incremental file format RFC [0]. The commit-graph feature is growing, thanks to all of the contributions by several community members. This also means that the write_commit_graph() method is a bit unwieldy now. This series refactors that method to use a write_commit_graph_context struct that is passed between several smaller methods. The final result should be a write_commit_graph() method that has a clear set of steps. Future changes should then be easier to understand. * Patches 1-4: these are small changes which either fix issues or just provide clean-up. These are mostly borrowed from ds/commit-graph-format-v2. * Patches 5-11: these provide a non-functional refactor of write_commit_graph() into several methods using a "struct write_commit_graph_context" to share across the methods. Updates to commits previously in this thread: * "commit-graph: remove Future Work section" no longer says that 'verify' takes as long as 'write'. [1] * "commit-graph: return with errors during write" now has a test to check we don't die(). [2] Ævar: Looking at the old thread, I only saw two comments that still apply to this series [1] [2]. Please point me to any comments I have missed. Updates in V5: * API calls are updated to return 0 on success and a negative value on failure. * Stopped passing 'errno' through an API function, instead returns -1. * "extracting methods" -> "extracting helper functions" in commit messages. * flags are now unsigned ints. Thanks, -Stolee [0] https://public-inbox.org/git/pull.184.git.gitgitgadget@gmail.com/ [1] https://public-inbox.org/git/87o94mql0a.fsf@evledraar.gmail.com/ [2] https://public-inbox.org/git/87pnp2qlkv.fsf@evledraar.gmail.com/ Derrick Stolee (11): commit-graph: fix the_repository reference commit-graph: return with errors during write commit-graph: collapse parameters into flags commit-graph: remove Future Work section commit-graph: create write_commit_graph_context commit-graph: extract fill_oids_from_packs() commit-graph: extract fill_oids_from_commit_hex() commit-graph: extract fill_oids_from_all_packs() commit-graph: extract count_distinct_commits() commit-graph: extract copy_oids_to_commits() commit-graph: extract write_commit_graph_file() Documentation/technical/commit-graph.txt | 17 - builtin/commit-graph.c | 22 +- builtin/commit.c | 5 +- builtin/gc.c | 7 +- commit-graph.c | 607 +++++++++++++---------- commit-graph.h | 20 +- commit.c | 2 +- t/t5318-commit-graph.sh | 8 + 8 files changed, 378 insertions(+), 310 deletions(-) base-commit: 93b4405ffe4ad9308740e7c1c71383bfc369baaa Submitted-As: https://public-inbox.org/git/pull.112.v5.git.gitgitgadget@gmail.com In-Reply-To: https://public-inbox.org/git/pull.112.git.gitgitgadget@gmail.com In-Reply-To: https://public-inbox.org/git/pull.112.v2.git.gitgitgadget@gmail.com In-Reply-To: https://public-inbox.org/git/pull.112.v3.git.gitgitgadget@gmail.com In-Reply-To: https://public-inbox.org/git/pull.112.v4.git.gitgitgadget@gmail.com
Assets 2
-
2019-06-12T13:29:34Z -
2019-06-12T13:29:34Z -