pr-1163/derrickstolee/gen-v3-v2
tagged this
28 Feb 13:53
This patch series fixes some bugs in generation number v2. They were discovered while building generation number v3, but that implementation will be delayed until these fixes are merged. In particular, Git has been ignoring corrected commit dates since shortly after they were introduced. This is due to a bug I introduced when trying to make split commit-graphs safer with mixed generation number versions. I also noticed an issue with the offset overflows that I only noticed after writing generation number v3 using a smaller offset size, actually triggering the bug in the test suite. Updates in v2 ============= * Dropped generation v3 patches, saving them for later. * Updated a commit message to more clearly describe the problem with the old code. * Used an || instead of two if statements in test script. Thanks, -Stolee Derrick Stolee (4): test-read-graph: include extra post-parse info commit-graph: fix ordering bug in generation numbers commit-graph: start parsing generation v2 (again) commit-graph: fix generation number v2 overflow values commit-graph.c | 15 +++++++++++---- t/helper/test-read-graph.c | 13 +++++++++++++ t/t4216-log-bloom.sh | 1 + t/t5318-commit-graph.sh | 34 +++++++++++++++++++++++++++++----- t/t5324-split-commit-graph.sh | 10 ++++++++++ 5 files changed, 64 insertions(+), 9 deletions(-) base-commit: dab1b7905d0b295f1acef9785bb2b9cbb0fdec84 Submitted-As: https://lore.kernel.org/git/pull.1163.v2.git.1646056423.gitgitgadget@gmail.com In-Reply-To: https://lore.kernel.org/git/pull.1163.git.1645735117.gitgitgadget@gmail.com
Assets 2
-
2022-02-28T13:53:43Z -
2022-02-28T13:53:43Z -