Skip to content

pr-1222/p1-gdd/fix/show-branch-segfault-v1

From: Gregory DAVID <gregory.david@p1sec.com>

If run `show-branch` with `--current` and `--reflog` simultaneously, a
SEGFAULT appears.

The bug is that we read over the end of the `reflog_msg` array after
having `append_one_rev()` for the current branch without supplying a
convenient message to it.

It seems that it has been introduced in: Commit
1aa68d6735 (show-branch: --current includes the current branch.,
2006-01-11)

Signed-off-by: Gregory DAVID <gregory.david@p1sec.com>
Thanks-to: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Submitted-As: https://lore.kernel.org/git/pull.1222.git.1650634704191.gitgitgadget@gmail.com
Assets 2