pr-1482/phillipwood/rebase-check-labels-v2
tagged this
20 Feb 14:19
From: Phillip Wood <phillip.wood@dunelm.org.uk> Check that the argument to the "label" and "update-ref" commands is a valid refname when the todo list is parsed rather than waiting until the command is executed. This means that the user can deal with any errors at the beginning of the rebase rather than having it stop halfway through due to a typo in a label name. The "update-ref" command is changed to reject single level refs as it is all to easy to type "update-ref branch" which is incorrect rather than "update-ref refs/heads/branch" Note that it is not straight forward to check the arguments to "reset" and "merge" commands as they may be any revision, not just a refname and we do not have an equivalent of check_refname_format() for revisions. Helped-by: Derrick Stolee <derrickstolee@github.com> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> Submitted-As: https://lore.kernel.org/git/pull.1482.v2.git.1676902774366.gitgitgadget@gmail.com In-Reply-To: https://lore.kernel.org/git/pull.1482.git.1676644675638.gitgitgadget@gmail.com
Assets 2
-
2023-02-20T14:19:34Z -
2023-02-20T14:19:34Z -