pr-629/chwarr/bisect-replay-crlf-v1
tagged this
07 May 21:29
From: Christopher Warrington <chwarr@microsoft.com> Sometimes bisect logs have CRLF newlines. (E.g., if they've been edited on a Windows machine and their LF-only nature wasn't preserved.) Previously, such log files would cause odd failures deep in the guts of git bisect, like "?? what are you talking about?" or "couldn't get the oid of the rev '...?'" (notice the trailing ?) as each line's CR ends up part of the final value read from the log. This commit fixes that by stripping CRs from the log before further processing. A regression test that fails without the git-bisect.sh change, "bisect replay with CRLF log" has been added as well. Were anyone to intentionally be using terms/revs with embedded CRs, replaying such bisects will no longer work with this change. I suspect that this is incredibly rare. Signed-off-by: Christopher Warrington <chwarr@microsoft.com> Submitted-As: https://lore.kernel.org/git/pull.629.git.1588886980377.gitgitgadget@gmail.com
Assets 2
-
2020-05-07T21:29:40Z -
2020-05-07T21:29:40Z -