Skip to content

pr-767/nipunn1313/fsmonitor-v1

Credit to alexmv again - I'm rebasing these changes from a couple years ago
for contribution.

Full comments are available here -
https://public-inbox.org/git/01ad47b4-aa5e-461a-270b-dd60032afbd1@gmail.com/
To summarize the relevant points

Re: Inlining mark_fsmonitor_[in]valid peartben said

I'm fine with these not being inline.  I was attempting to minimize the
performance impact of the fsmonitor code when it was not even turned on.
  Inlineing these functions allowed it to be kept to a simple test but I
suspect (especially with modern optimizing compilers) that the overhead
of calling a function to do that test is negligible.

Re test-dump-fsmonitor peartben suggested keeping the +- syntax as well as
the summary counts dscho suggested dumping the invalid entries

Alex Vandiver (2):
  fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid
  fsmonitor: make output of test-dump-fsmonitor more concise

 fsmonitor.c                    | 19 +++++++++++++++++++
 fsmonitor.h                    | 18 ++----------------
 t/helper/test-dump-fsmonitor.c | 14 ++++++++++++--
 3 files changed, 33 insertions(+), 18 deletions(-)

base-commit: 69986e19ffcfb9af674ae5180689ab7bbf92ed28

Submitted-As: https://lore.kernel.org/git/pull.767.git.1603303474.gitgitgadget@gmail.com
Assets 2