Skip to content

pr-git-1152/hanwen/reftable-coverity-v7

This series was targeted to 'master'.

This addresses some complaints from Coverity that Peff reported.

v7:

 * address avarab's comments.

Han-Wen Nienhuys (16):
  reftable: fix OOB stack write in print functions
  reftable: fix resource leak in block.c error path
  reftable: fix resource leak blocksource.c
  reftable: check reftable_stack_auto_compact() return value
  reftable: ignore remove() return value in stack_test.c
  reftable: fix resource warning
  reftable: all xxx_free() functions accept NULL arguments
  reftable: order unittests by complexity
  reftable: drop stray printf in readwrite_test
  reftable: handle null refnames in reftable_ref_record_equal
  reftable: make reftable-record.h function signatures const correct
  reftable: implement record equality generically
  reftable: remove outdated file reftable.c
  reftable: make reftable_record a tagged union
  reftable: add print functions to the record types
  reftable: rename typ to type

 reftable/block.c           |  35 ++--
 reftable/block_test.c      |  22 +--
 reftable/blocksource.c     |   6 +-
 reftable/generic.c         |  39 ++--
 reftable/iter.c            |   4 +-
 reftable/merged.c          |  35 ++--
 reftable/merged.h          |   2 +-
 reftable/pq.c              |   2 +-
 reftable/pq_test.c         |  29 ++-
 reftable/reader.c          | 167 +++++++++--------
 reftable/readwrite_test.c  |  67 ++++++-
 reftable/record.c          | 367 +++++++++++++++++++++++--------------
 reftable/record.h          |  49 ++---
 reftable/record_test.c     | 193 +++++++++----------
 reftable/reftable-record.h |  14 +-
 reftable/reftable.c        | 115 ------------
 reftable/stack.c           |  10 +-
 reftable/stack_test.c      |   3 +-
 reftable/writer.c          |  72 ++++----
 t/helper/test-reftable.c   |   9 +-
 20 files changed, 666 insertions(+), 574 deletions(-)
 delete mode 100644 reftable/reftable.c

base-commit: 50b2d72e110cad39ecaf2322bfdf1b60cd13dd96

Submitted-As: https://lore.kernel.org/git/pull.1152.v7.git.git.1643051624.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.git.git.1638899124.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.v2.git.git.1639000187.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.v3.git.git.1639411309.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.v4.git.git.1639482476.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.v5.git.git.1640199396.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1152.v6.git.git.1642691534.gitgitgadget@gmail.com
Assets 2