Skip to content

pr-git-1469/hickford/libsecret-v4

From: M Hickford <mirth.hickford@gmail.com>

d208bfd (credential: new attribute password_expiry_utc, 2023-02-18)
and a5c76569e7 (credential: new attribute oauth_refresh_token)
introduced new credential attributes.

libsecret assumes attribute values are non-confidential and
unchanging, so we encode the new attributes in the secret, separated by
newline:

    hunter2
    password_expiry_utc=1684189401
    oauth_refresh_token=xyzzy

This is extensible and backwards compatible. The credential protocol
already assumes that attribute values do not contain newlines.

Alternatives considered: store password_expiry_utc in a libsecret
attribute. This has the problem that libsecret creates new items
rather than overwrites when attribute values change.

Signed-off-by: M Hickford <mirth.hickford@gmail.com>

Submitted-As: https://lore.kernel.org/git/pull.1469.v4.git.git.1684306540947.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1469.git.git.1678829531648.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1469.v2.git.git.1679729764851.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.1469.v3.git.git.1683270298313.gitgitgadget@gmail.com
Assets 2