Skip to content

pr-git-676/newren/ls-files-bug-v5

This series documents multiple fill_directory() bugs, and fixes the one that
is new to 2.24.0 coming from en/clean-nested-with-ignored-topic, the rest
having been around in versions of git going back up to a decade.

Changes since v4:

 * added a comment with the rationale for allocating an extra len+1 bytes
   for the dirent.

Elijah Newren (8):
  t3011: demonstrate directory traversal failures
  Revert "dir.c: make 'git-status --ignored' work within leading
    directories"
  dir: remove stray quote character in comment
  dir: exit before wildcard fall-through if there is no wildcard
  dir: break part of read_directory_recursive() out for reuse
  dir: fix checks on common prefix directory
  dir: synchronize treat_leading_path() and read_directory_recursive()
  dir: consolidate similar code in treat_directory()

 dir.c                                         | 187 ++++++++++++----
 ...common-prefixes-and-directory-traversal.sh | 209 ++++++++++++++++++
 t/t7061-wtstatus-ignore.sh                    |   9 +-
 3 files changed, 354 insertions(+), 51 deletions(-)
 create mode 100755 t/t3011-common-prefixes-and-directory-traversal.sh

base-commit: da72936f544fec5a335e66432610e4cef4430991

Submitted-As: https://lore.kernel.org/git/pull.676.v5.git.git.1576790906.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.676.git.git.1575924465.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.676.v2.git.git.1576008027.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.676.v3.git.git.1576571586.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.676.v4.git.git.1576697386.gitgitgadget@gmail.com
Assets 2