Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Feature: open in Safari VC (instead of just Safari) #17

Closed
BasThomas opened this issue Jun 27, 2017 · 5 comments
Closed

Feature: open in Safari VC (instead of just Safari) #17

BasThomas opened this issue Jun 27, 2017 · 5 comments
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@BasThomas
Copy link
Collaborator

No description provided.

@rnystrom rnystrom added the 🆕 feature request A feature being requested to be added, not yet approved label Jun 27, 2017
@rnystrom
Copy link
Member

This is for viewing issues on the web, right? Good idea, I'll update that.

@BasThomas
Copy link
Collaborator Author

Yes, that's the use case :)

@BasThomas
Copy link
Collaborator Author

Not sure if this is possible... played around with it for a bit (https://github.com/BasThomas/SafariVCActivity) but I can't seem to get it to work.

Doing this kind of works, but is hacky and still has some issues with dismissing the SafariVC.

Doing this is what I expected to "just work", but gives me a white screen with the view hierarchy as shown below.

screen shot 2017-06-27 at 22 49 47

So, 🤷‍♂️

@rnystrom
Copy link
Member

I can just change the menu to an alert control that has:

  • Open in Safari
  • Share...

I'll need that context menu for other stuff in the future:

  • Close/re-open
  • etc

@BasThomas
Copy link
Collaborator Author

Yeah, I wanted the "fancy" option. Of course that would work, should've it clearer that I was referring to using a UIActivity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

2 participants