Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Layout not updated on screen change #7

Closed
BasThomas opened this issue Jun 25, 2017 · 3 comments
Closed

Layout not updated on screen change #7

BasThomas opened this issue Jun 25, 2017 · 3 comments
Milestone

Comments

@BasThomas
Copy link
Collaborator

When changing orientation or the app's size in splitview on iPad, the layout isn't updated. Clicking something that causes some sort of refresh (focus on account in settings, switching state in notifications) fixes this. How can this be resolved best?

Impact: everything (except GitHubLogin.storyboard)

In a thread, tapping a comment fixes it only partially; the textview width is not updated.

Screenshots

simulator screen shot 25 jun 2017 16 36 23

simulator screen shot 25 jun 2017 16 36 28

simulator screen shot 25 jun 2017 16 36 31

simulator screen shot 25 jun 2017 16 36 37

simulator screen shot 25 jun 2017 16 36 44

simulator screen shot 25 jun 2017 16 36 55

@rnystrom
Copy link
Member

Yup! Def a known issue. Going to have to figure out how to best clear text size and render caches when rotating. Think I have an idea...

@rnystrom rnystrom added this to the 1.0.0 milestone Jun 25, 2017
@weyert
Copy link
Contributor

weyert commented Jun 26, 2017

Can't you listen to the orientation notification and clear the cache? Or would that cause a racing condition?

@rnystrom
Copy link
Member

Fixed

@weyert I'm using sort-of-immutable models for this, but trying to dependency inject text+sizing models to the section controllers + cells that use them. Really trying to promote the "one way data flow" in this app w/out hacks. Also avoiding "global" caches and notification systems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants