-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #472 from 2taesung/refactor/view-type
refactor(view): engine과 공통되는 temp 타입 정리 및 주석
- Loading branch information
Showing
6 changed files
with
53 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import type { DiffStatistics } from "./DiffStatistics"; | ||
import type { GitHubUser } from "./GitHubUser"; | ||
|
||
export type Commit = { | ||
id: string; | ||
parentIds: string[]; | ||
author: GitHubUser; | ||
committer: GitHubUser; | ||
authorDate: string; | ||
commitDate: string; | ||
diffStatistics: DiffStatistics; | ||
message: string; | ||
// fill necessary properties... | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// This file here is all identical to 'types/CommitMessageType.ts' in 'analysis-engine'. | ||
// Since the commit is originally imported from b, this file can be changed when b changes. | ||
// You can create types derived from this code. | ||
// However, design so that errors do not occur even if this code is changed. | ||
export const CommitMessageTypeList = [ | ||
"build", | ||
"chore", | ||
"ci", | ||
"docs", | ||
"feat", | ||
"fix", | ||
"pert", | ||
"refactor", | ||
"revert", | ||
"style", | ||
"test", | ||
"", // default - 명시된 타입이 없거나 commitLint rule을 따르지 않은 경우 | ||
]; | ||
|
||
const COMMIT_MESSAGE_TYPE = [...CommitMessageTypeList] as const; | ||
|
||
export type CommitMessageType = (typeof COMMIT_MESSAGE_TYPE)[number]; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export type DiffStatistics = { | ||
changedFileCount: number; | ||
insertions: number; | ||
deletions: number; | ||
files: { | ||
[id: string]: { | ||
insertions: number; | ||
deletions: number; | ||
}; | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export type GitHubUser = { | ||
id: string; | ||
names: string[]; | ||
emails: string[]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters